Skip to content

Commit

Permalink
fix(ingest/gc): minor tweak gc source (datahub-project#12093)
Browse files Browse the repository at this point in the history
  • Loading branch information
anshbansal authored Dec 11, 2024
1 parent becf515 commit 54d53cf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions metadata-ingestion/src/datahub/ingestion/source/gc/datahub_gc.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,6 @@ def get_workunits_internal(
self.truncate_indices()
except Exception as e:
self.report.failure("While trying to truncate indices ", exc=e)
if self.dataprocess_cleanup:
try:
yield from self.dataprocess_cleanup.get_workunits_internal()
except Exception as e:
self.report.failure("While trying to cleanup data process ", exc=e)
if self.soft_deleted_entities_cleanup:
try:
self.soft_deleted_entities_cleanup.cleanup_soft_deleted_entities()
Expand All @@ -170,6 +165,11 @@ def get_workunits_internal(
self.execution_request_cleanup.run()
except Exception as e:
self.report.failure("While trying to cleanup execution request ", exc=e)
if self.dataprocess_cleanup:
try:
yield from self.dataprocess_cleanup.get_workunits_internal()
except Exception as e:
self.report.failure("While trying to cleanup data process ", exc=e)
yield from []

def truncate_indices(self) -> None:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class SoftDeletedEntitiesCleanupConfig(ConfigModel):
description="Query to filter entities",
)
limit_entities_delete: Optional[int] = Field(
10000, description="Max number of entities to delete."
25000, description="Max number of entities to delete."
)

runtime_limit_seconds: Optional[int] = Field(
Expand Down

0 comments on commit 54d53cf

Please sign in to comment.