fix(terms): fix removing terms from schema field & add cypress tests …

…to cover these flows (datahub-project#4091)
acryldata · Feb 8, 2022 · 306fe0b · 306fe0b
1 parent f5a51f0
commit 306fe0b
Show file tree

Hide file tree

Showing 5 changed files with 70 additions and 19 deletions.
diff --git a/...hql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/mutate/util/LabelUtils.java b/...hql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/mutate/util/LabelUtils.java
@@ -66,7 +66,7 @@ public static void removeTermFromTarget(
       }
 
       removeTermIfExists(editableFieldInfo.getGlossaryTerms(), labelUrn);
-      persistAspect(targetUrn, GLOSSARY_TERM_ASPECT_NAME, editableSchemaMetadata, actor, entityService);
+      persistAspect(targetUrn, EDITABLE_SCHEMA_METADATA, editableSchemaMetadata, actor, entityService);
     }
   }
 

diff --git a/...hub-web-react/src/app/entity/shared/tabs/Dataset/Schema/utils/useTagsAndTermsRenderer.tsx b/...hub-web-react/src/app/entity/shared/tabs/Dataset/Schema/utils/useTagsAndTermsRenderer.tsx
@@ -19,21 +19,23 @@ export default function useTagsAndTermsRenderer(
         );
 
         return (
-            <TagTermGroup
-                uneditableTags={options.showTags ? tags : null}
-                editableTags={options.showTags ? relevantEditableFieldInfo?.globalTags : null}
-                uneditableGlossaryTerms={options.showTerms ? record.glossaryTerms : null}
-                editableGlossaryTerms={options.showTerms ? relevantEditableFieldInfo?.glossaryTerms : null}
-                canRemove
-                buttonProps={{ size: 'small' }}
-                canAddTag={tagHoveredIndex === `${record.fieldPath}-${rowIndex}` && options.showTags}
-                canAddTerm={tagHoveredIndex === `${record.fieldPath}-${rowIndex}` && options.showTerms}
-                onOpenModal={() => setTagHoveredIndex(undefined)}
-                entityUrn={urn}
-                entityType={EntityType.Dataset}
-                entitySubresource={record.fieldPath}
-                refetch={refetch}
-            />
+            <div data-testid={`schema-field-${record.fieldPath}-${options.showTags ? 'tags' : 'terms'}`}>
+                <TagTermGroup
+                    uneditableTags={options.showTags ? tags : null}
+                    editableTags={options.showTags ? relevantEditableFieldInfo?.globalTags : null}
+                    uneditableGlossaryTerms={options.showTerms ? record.glossaryTerms : null}
+                    editableGlossaryTerms={options.showTerms ? relevantEditableFieldInfo?.glossaryTerms : null}
+                    canRemove
+                    buttonProps={{ size: 'small' }}
+                    canAddTag={tagHoveredIndex === `${record.fieldPath}-${rowIndex}` && options.showTags}
+                    canAddTerm={tagHoveredIndex === `${record.fieldPath}-${rowIndex}` && options.showTerms}
+                    onOpenModal={() => setTagHoveredIndex(undefined)}
+                    entityUrn={urn}
+                    entityType={EntityType.Dataset}
+                    entitySubresource={record.fieldPath}
+                    refetch={refetch}
+                />
+            </div>
         );
     };
     return tagAndTermRender;

diff --git a/datahub-web-react/src/app/shared/tags/AddTagTermModal.tsx b/datahub-web-react/src/app/shared/tags/AddTagTermModal.tsx
@@ -236,7 +236,11 @@ export default function AddTagTermModal({
                     <Button onClick={onClose} type="text">
                         Cancel
                     </Button>
-                    <Button onClick={onOk} disabled={selectedValue.length === 0 || disableAdd}>
+                    <Button
+                        data-testid="add-tag-term-from-modal-btn"
+                        onClick={onOk}
+                        disabled={selectedValue.length === 0 || disableAdd}
+                    >
                         Add
                     </Button>
                 </>

diff --git a/datahub-web-react/src/app/shared/tags/TagTermGroup.tsx b/datahub-web-react/src/app/shared/tags/TagTermGroup.tsx
@@ -229,7 +229,7 @@ export default function TagTermGroup({
                     {...buttonProps}
                 >
                     <PlusOutlined />
-                    Add Tag
+                    <span>Add Tag</span>
                 </NoElementButton>
             )}
             {canAddTerm &&
@@ -243,7 +243,7 @@ export default function TagTermGroup({
                         {...buttonProps}
                     >
                         <PlusOutlined />
-                        Add Term
+                        <span>Add Term</span>
                     </NoElementButton>
                 )}
             {showAddModal && !!entityUrn && !!entityType && (

diff --git a/smoke-test/tests/cypress/cypress/integration/mutations/mutations.js b/smoke-test/tests/cypress/cypress/integration/mutations/mutations.js
@@ -37,4 +37,49 @@ describe('mutations', () => {
 
     cy.deleteUrn('urn:li:tag:CypressTestAddTag')
   });
+
+  it('can add and remove terms from a dataset', () => {
+    cy.login();
+    cy.visit('/dataset/urn:li:dataset:(urn:li:dataPlatform:hive,cypress_logging_events,PROD)');
+    cy.contains('cypress_logging_events');
+
+    cy.contains('Add Term').click();
+
+    cy.focused().type('CypressTerm');
+
+    cy.get('.ant-select-item-option-content').within(() => cy.contains('CypressNode.CypressTerm').click({force: true}));
+
+    cy.get('[data-testid="add-tag-term-from-modal-btn"]').click({force: true});
+    cy.get('[data-testid="add-tag-term-from-modal-btn"]').should('not.exist');
+
+    cy.contains('CypressTerm');
+
+    cy.get('a[href="/glossary/urn:li:glossaryTerm:CypressNode.CypressTerm"]').within(() => cy.get('span[aria-label=close]').click());
+    cy.contains('Yes').click();
+
+    cy.contains('CypressTerm').should('not.exist');
+  });
+
+  it('can add and remove terms from a dataset field', () => {
+    cy.login();
+    // make space for the glossary term column
+    cy.viewport(1300, 800)
+    cy.visit('/dataset/urn:li:dataset:(urn:li:dataPlatform:hive,cypress_logging_events,PROD)');
+    cy.get('[data-testid="schema-field-event_name-terms"]').trigger('mouseover', {force: true});
+    cy.get('[data-testid="schema-field-event_name-terms"]').within(() => cy.contains('Add Term').click())
+
+    cy.focused().type('CypressTerm');
+
+    cy.get('.ant-select-item-option-content').within(() => cy.contains('CypressNode.CypressTerm').click({force: true}));
+
+    cy.get('[data-testid="add-tag-term-from-modal-btn"]').click({force: true});
+    cy.get('[data-testid="add-tag-term-from-modal-btn"]').should('not.exist');
+
+    cy.contains('CypressTerm');
+
+    cy.get('a[href="/glossary/urn:li:glossaryTerm:CypressNode.CypressTerm"]').within(() => cy.get('span[aria-label=close]').click());
+    cy.contains('Yes').click();
+
+    cy.contains('CypressTerm').should('not.exist');
+  });
 })
-Original file line number
+Diff line change
@@ Expand Up / @@ -66,7 +66,7 @@ public static void removeTermFromTarget( @@
           }
           removeTermIfExists(editableFieldInfo.getGlossaryTerms(), labelUrn);
-          persistAspect(targetUrn, GLOSSARY_TERM_ASPECT_NAME, editableSchemaMetadata, actor, entityService);
+          persistAspect(targetUrn, EDITABLE_SCHEMA_METADATA, editableSchemaMetadata, actor, entityService);
         }
       }
@@ Expand Down @@