Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kafka): increase kafka chart version due to kraft enabled error #378

Merged
merged 2 commits into from
Oct 12, 2023
Merged

fix(kafka): increase kafka chart version due to kraft enabled error #378

merged 2 commits into from
Oct 12, 2023

Conversation

janfrederickk
Copy link
Contributor

@janfrederickk janfrederickk commented Oct 12, 2023 •
edited
Loading

This MR fixes used kafka helm chart due to error when using kraft and helm drift detection

related issue: #377

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@janfrederickk janfrederickk changed the title fix: increase kafka chart version due to kraft enabled error fix(kafka): increase kafka chart version due to kraft enabled error Oct 12, 2023
pedro93
pedro93 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedro93 pedro93 merged commit 826bf3b into acryldata:master Oct 12, 2023
dheerajrampally pushed a commit to dheerajrampally/datahub-helm that referenced this pull request Oct 20, 2023
@janfrederickk @janwackermark @dheerajrampally
fix(kafka): increase kafka chart version due to kraft enabled error (a…
1c33ee0 
…cryldata#378)

* fix: increase kafka chart version due to kraft enabled error

* increse prerequisites helm chart version

---------

Co-authored-by: Wacker <[email protected]>
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@janfrederickk @pedro93 @maggiehays @janwackermark