Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inventory-manager): Wrap ETH on Arbitrum #969

Merged
merged 10 commits into from
Oct 6, 2023
Merged

Conversation

nicholaspai
Copy link
Member

We expect ETH to be sent to the relayer address on Arbitrum because its
hardcoded as a refund address for all HubPool messages
that get sent to the ArbitrumSpoke.

nicholaspai and others added 2 commits October 6, 2023 12:52
We expect ETH to be sent to the relayer address on Arbitrum because its [hardcoded](https://github.com/across-protocol/contracts-v2/blob/3634df5ec327326ce030629aa0a089f651f20bc0/contracts/chain-adapters/Arbitrum_Adapter.sol#L158) as a refund address for all HubPool messages that get sent to the ArbitrumSpoke.
@nicholaspai nicholaspai marked this pull request as ready for review October 6, 2023 17:41
src/clients/bridges/ArbitrumAdapter.ts Outdated Show resolved Hide resolved
src/clients/bridges/ArbitrumAdapter.ts Outdated Show resolved Hide resolved
src/utils/CLIUtils.ts Outdated Show resolved Hide resolved
@nicholaspai nicholaspai requested a review from pxrl October 6, 2023 18:36
Copy link
Contributor

@pxrl pxrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor cosmetic comments 👍

src/clients/bridges/BaseAdapter.ts Outdated Show resolved Hide resolved
src/relayer/RelayerConfig.ts Outdated Show resolved Hide resolved
@nicholaspai nicholaspai merged commit 536b394 into master Oct 6, 2023
2 checks passed
@pxrl pxrl deleted the npai/arbitrum-wrap branch March 20, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants