fix: Restore privateKey wallet validation #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
privateKey is case sensitive.
pxrl
requested review from
mrice32,
nicholaspai and
james-a-morris
as code owners
mrice32
approved these changes
Oct 5, 2023
nicholaspai
pushed a commit
that referenced
this pull request
Oct 6, 2023
privateKey is case sensitive.
nicholaspai
added a commit
that referenced
this pull request
Oct 6, 2023
* feat(inventory-manager): Wrap ETH on Arbitrum We expect ETH to be sent to the relayer address on Arbitrum because its [hardcoded](https://github.com/across-protocol/contracts-v2/blob/3634df5ec327326ce030629aa0a089f651f20bc0/contracts/chain-adapters/Arbitrum_Adapter.sol#L158) as a refund address for all HubPool messages that get sent to the ArbitrumSpoke. * fix: Restore privateKey wallet validation (#968) privateKey is case sensitive. * fix asserts * WIP * Update src/clients/bridges/BaseAdapter.ts Co-authored-by: Paul <[email protected]> * Update src/clients/bridges/BaseAdapter.ts Co-authored-by: Paul <[email protected]> * Update BaseAdapter.ts * Add configurable target/threshold * lint --------- Co-authored-by: Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
privateKey is case sensitive.