improve(Constants): Update default deposit confirmations #1968
+20
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing defaults are set so conservatively that third-party operators are pushed into overriding them with custom values. This introduces a greater risk of loss of funds. Instead, update the defaults with lower confirmation requirements that should permit new operators to make fills successfully without having to discard the defaults.
pxrl
requested review from
mrice32,
nicholaspai,
james-a-morris and
dohaki
as code owners
nicholaspai
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing defaults are set so conservatively that third-party operators are pushed into overriding them with custom values. This introduces a greater risk of loss of funds. Instead, update the defaults with lower confirmation requirements that should permit new operators to make fills successfully without having to discard the defaults.
As a side benefit, this will marginally simplify the process of onboard OP or Orbit chains.