refactor(AdapterManager): define base chain adapters programmatically #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bennett <[email protected]>
bmzig
requested review from
mrice32,
nicholaspai,
pxrl,
james-a-morris and
dohaki
as code owners
bmzig
commented
Dec 31, 2024
nicholaspai
approved these changes
Dec 31, 2024
james-a-morris
approved these changes
Jan 2, 2025
pxrl
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last change of code needed to fully switch to generic adapters. It was delayed so that these new base chain adapters would be out in the wild for long enough such that it is unlikely for them to contain any critical issues. This PR will effectively make all of the named adapters (e.g. ZKSyncAdapter, ArbitrumAdapter, CCTPAdapter, BaseAdapter, etc.) in
src/client/bridgesunused code (to be deleted in a follow-up), and also make the entireop-stackdirectory unused.To be clear, there is still a substantial amount of code which needs to be removed, but all further follow-up removals will have no affect on the bots, since we would be removing code which is only touched in out-of-date unit tests.