chore(gckms): add file support for GCKMS_CONFIG env var
#1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamazad
requested review from
mrice32,
nicholaspai,
pxrl and
james-a-morris
as code owners
adamazad
changed the title
GCKMS_CONFIG env varGCKMS_CONFIG env var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for file paths in the
GCKMS_CONFIGenvironment variable, allowing configurations to be loaded from a file or directly from an inline JSON string. It improves error handling with clear messages for missing or empty configurations and refines the.GckmsOverride.jslogic for better maintainability. These changes enhance flexibility and simplify integration with various deployment setups.