improve(LineaFinalizer): Force RPC calls through custom provider #1931
Conversation
The functions that we use in the Linea SDK make event queries from block 0 to "latest" by default which means that some of our RPC's can't be used with the Finalizer. Additionally, we're missing out our custom provider retry and caching logic. This PR removes all instances of making RPC calls via the Linea SDK's provider and replace with making the same call through our custom Provider. The latest [Linea SDK](https://github.com/Consensys/linea-monorepo/blob/3fbe660683a318b6fa1b63ec518f948791536352/sdk/src/sdk/LineaSDK.ts#L56) code looks like it'll support injecting custom providers but its not released yet on NPM. So this code should be removed eventually once a later SDK version is released.
nicholaspai
requested review from
mrice32,
pxrl and
james-a-morris
as code owners
I haven't been able to time it well. I think one way to do it is i can temporarily pause the production finalizer for linea and run this locally. |
There was a problem hiding this comment.
This makes sense but I think we should avoid accessing the Linea package in an unintended way. We've forked/patched packages before so that they play nicely with our imports - this could be a viable workaround.
Otherwise there's nothing that stands out - I'll approve pending my comments
Yes, now I have: https://etherscan.io/tx/0xdd512394eb0aed5b44ae4c9ed6619937555d8d67d7f8795e4c82f060cdbcce94 |
I think the issue here is that the entire linea/ folder will change, the code is very different |
The functions that we use in the Linea SDK make event queries from block 0 to "latest" by default which means that some of our RPC's can't be used with the Finalizer. Additionally, we're missing out our custom provider retry and caching logic.
This PR removes all instances of making RPC calls via the Linea SDK's provider and replace with making the same call through our custom Provider.
The latest Linea SDK code looks like it'll support injecting custom providers but its not released yet on NPM. So this code should be removed eventually once a later SDK version is released.
This PR also fixes a bug where the existing SDK's interface doesn't match what's on chain: 12e872e