improve(relayer): Pass SpokePool addresses to listener processes #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This skips an RPC call per SpokePool listener in the fast relayer configuration, and permits each SpokePool listener instance to communicate with only a single chain, instead of having to always query mainnet to resolve the current SpokePool address.
pxrl
requested review from
mrice32,
nicholaspai and
james-a-morris
as code owners
nicholaspai
reviewed
Nov 11, 2024
nicholaspai
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Just one question: https://github.com/across-protocol/relayer/pull/1902/files#r1836825620
pxrl
changed the title
nicholaspai
approved these changes
Nov 14, 2024
james-a-morris
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips an RPC call per SpokePool listener in the fast relayer configuration, and permits each SpokePool listener instance to communicate with only a single chain, instead of having to always query mainnet to resolve the current SpokePool address. In case the caller does not supply the SpokePool address, the listener process will fall back to the address specified in the contracts repository.