fix(relayer): Use precomputed gas limits #1876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The relayer has had a bug for a while where it is incorrectly dropping the precomputed gas limit for non-message fills. Instead, it was retaining the limit for message fills. This can lead to unnecessary transaction simulation later on, increasing RPC consumption and potentially delaying fills.
pxrl
requested review from
mrice32,
nicholaspai and
james-a-morris
as code owners
nicholaspai
previously approved these changes
Oct 25, 2024
pxrl
changed the title
|
One thing holding this back: some ERC20s consume a lot more gas on transfers than others. This PR would probably break filling for SNX and UMA at least. |
james-a-morris
previously approved these changes
Oct 25, 2024
pxrl
changed the title
Fixed by precomputing all types on startup: 6bf012a This isn't as efficient as it could be, but it still miles better than the current status quo that's performing simulation for every single fill. |
pxrl
dismissed stale reviews from james-a-morris and nicholaspai
via
276b191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relayer has had a bug for a while where it is incorrectly dropping the precomputed gas limit for non-message fills. Instead, it was retaining the limit for message fills. This can lead to unnecessary transaction simulation later on, increasing RPC consumption and potentially delaying fills.
In practice, it's totally unnecessary for the top-level relayer logic to consider whether the deposit has a message at all. This is because the ProfitClient handles that internally and takes responsibility for setting the gas limit. It's inherently required to do this because otherwise the relayer risks making a vastly unprofitable fill (if gas consumption varies between the initial estimate and any subsequent estimate).