feat(InventoryClient): Support 1:many HubPool mappings #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only append unwrapWethThreshold for WETH. - Dereference the l1Token/chainId pair for less repetition.
This change permits the InventoryConfig to be specified in either HubPool token address or token symbol. Token symbol is preferred because it's simpler to configure and reduces the chance of mistakes. During config, any symbols are resolved to their underlying token addresses on the HubPool chain, so no subsequent changes are required for any accesses into the post-processed inventory config.
This update to the InventoryClient permits multiple tokens to map to a
single HubPool token. This will be used with USDC/CCTP, where the
existing USDC deployment will map to both native USDC and bridged USDC
on the various non-mainnet chains supported by Across. See below for an
example of how this is configured. Note that the symbol _USDC is the
temporary label for native USDC.
"USDC": {
"USDC.e": {
"10": { "targetPct": 8, "thresholdPct": 4 },
"137": { "targetPct": 4, "thresholdPct": 1 },
"324": { "targetPct": 8, "thresholdPct": 4 },
"42161": { "targetPct": 8, "thresholdPct": 4 },
"59144": { "targetPct": 5, "thresholdPct": 2 }
},
"USDbC": {
"8453": { "targetPct": 5, "thresholdPct": 2 }
},
"_USDC": {
"137": { "targetPct": 1, "thresholdPct": 1 }
}
},
pxrl
commented
Apr 30, 2024
nicholaspai
reviewed
May 1, 2024
pxrl
commented
May 2, 2024
Prompted by Matt.
…1475) * refactor(CrossChainTransferClient): Support unique L2 tokens in adapters & cctc --------- Signed-off-by: james-a-morris <[email protected]> Co-authored-by: Paul <[email protected]>
Identified w/ James.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update to the InventoryClient permits multiple tokens to map to a single HubPool token. This will be used with USDC/CCTP, where the existing USDC deployment will map to both native USDC and bridged USDC on the various non-mainnet chains supported by Across. See below for an example of how this is configured. Note that the symbol _USDC is the temporary label for native USDC.