improve(relayer): Execute destination transactions async #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the relayer to submit transactions as soon as they are ready for each destination chain, rather than waiting until all destination transaction queues are ready. This should reduce the overall execution time for the relayer when it has transactions to submit on multiple chains, and should improve relayer performance on chains with a high chainId.
pxrl
requested review from
mrice32,
nicholaspai and
james-a-morris
as code owners
pxrl
commented
Mar 25, 2024
nicholaspai
reviewed
Mar 25, 2024
nicholaspai
reviewed
Mar 25, 2024
nicholaspai
approved these changes
Mar 25, 2024
|
Status on this PR: thinking about a better way of verifying in tests; relying solely on log inspection isn't great. |
This has been resolved in this commit: 7d61b81 |
nicholaspai
approved these changes
Apr 2, 2024
mrice32
added a commit
that referenced
this pull request
Apr 4, 2024
…)" This reverts commit 2c1d2ae.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the relayer to submit transactions as soon as they are ready for each destination chain, rather than waiting until all destination transaction queues are ready. This should reduce the overall execution time for the relayer when it has transactions to submit on multiple chains, and should improve relayer performance on chains with a high chainId.