fix(relayer): Remove redundant array manipulation #1341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxrl
requested review from
mrice32,
nicholaspai and
james-a-morris
as code owners
nicholaspai
approved these changes
Mar 21, 2024
james-a-morris
approved these changes
Mar 21, 2024
src/relayer/Relayer.ts
Outdated
| @@ -258,7 +258,9 @@ export class Relayer { | |||
| // Fetch unfilled deposits and filter out deposits upfront before we compute the minimum deposit confirmation | |||
| // per chain, which is based on the deposit volume we could fill. | |||
| const unfilledDeposits = await this._getUnfilledDeposits(); | |||
| const allUnfilledDeposits = Object.values(unfilledDeposits.map(({ deposit }) => deposit)); | |||
| const allUnfilledDeposits = Object.values(unfilledDeposits) | |||
| .flat() | |||
There was a problem hiding this comment.
I guess the destructuring of { deposit } left deposit === undefined? Good find
There was a problem hiding this comment.
It wasn't as bad as I first thought - unfilledDeposits is already a flat array, so the extra Object.values() was just redundant code.
pxrl
changed the title
|
Closing this because it's only a superficial issue and will be cleaned up in a subsequent commit that already touches this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was recently touched; it's an error without any apparent side-effects.