Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(relayer): Post-process external inventory config #1333

Merged
merged 12 commits into from
Mar 25, 2024
Merged

fix(relayer): Post-process external inventory config #1333

merged 12 commits into from
Mar 25, 2024

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Mar 21, 2024 •
edited
Loading

The recent change to support externally-defined inventory configs neglected to post-process the imported config. It's important to scale each configured amount before taking the config into use.

james-a-morris
james-a-morris reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on placing the inventory config lookup in the helper rather than in the config class itself. Even an async function to load the externalInventoryConfigURI could be a good step

src/relayer/RelayerClientHelper.ts Outdated Show resolved Hide resolved
@pxrl pxrl requested a review from james-a-morris March 22, 2024 19:44
james-a-morris
james-a-morris approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pxrl pxrl merged commit 3213842 into master Mar 25, 2024
4 checks passed
@pxrl pxrl deleted the pxrl/fixExternalInventory branch March 25, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-a-morris james-a-morris james-a-morris approved these changes

@nicholaspai nicholaspai nicholaspai approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pxrl @nicholaspai @james-a-morris