Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve(linea): add outstanding contracts #1332

Merged
merged 14 commits into from
Mar 21, 2024
Merged

improve(linea): add outstanding contracts #1332

merged 14 commits into from
Mar 21, 2024

Conversation

james-a-morris
Copy link
Contributor

WIP

dohaki
dohaki approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@dohaki dohaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm

pxrl
pxrl approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@pxrl pxrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems OK - I only have a few style suggestions.

src/clients/bridges/LineaAdapter.ts Outdated Show resolved Hide resolved
src/clients/bridges/LineaAdapter.ts Outdated Show resolved Hide resolved
src/clients/bridges/LineaAdapter.ts Outdated Show resolved Hide resolved
nicholaspai
nicholaspai approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conceptually makes sense. Hard to know whether it works without testing with real events. How has testing been?

@james-a-morris james-a-morris marked this pull request as ready for review March 21, 2024 12:52
@james-a-morris james-a-morris requested a review from mrice32 as a code owner March 21, 2024 12:52
@james-a-morris james-a-morris requested a review from pxrl March 21, 2024 13:13
james-a-morris and others added 4 commits March 21, 2024 10:29
@james-a-morris
fix: use l1Token
f974dec
@pxrl
fix
c70fe2b
@james-a-morris @pxrl @nicholaspai
feat(finalizer): make l1l2 routes generic (#1328)
53b23ce 
* feat(finalizer): make l1l2 routes generic

* chore: revert index

* nit: include linea in non-overrides

* wip

* improve: overhaul generic finalizer

* nit

* Exclude missing SpokePoolClient instances

* nit: also compare positive `_value`

* nit: remove unneeded type

* feat: Activate linea adapter manager (#1325)

Co-authored-by: Paul <[email protected]>

* Update LineaAdapter.ts

* Update LineaAdapter.ts

* tweak

* Update Constants.ts

* Fix

* Update LineaAdapter.ts

* Update LineaAdapter.ts

* Revert "Update LineaAdapter.ts"

This reverts commit a1a4943.

---------

Co-authored-by: Paul <[email protected]>
Co-authored-by: nicholaspai <[email protected]>
Co-authored-by: nicholaspai <[email protected]>
@nicholaspai
Update common.ts
e546bb5
@james-a-morris james-a-morris merged commit efcc47c into master Mar 21, 2024
4 checks passed
@pxrl pxrl deleted the james/add-outstanding-contracts branch September 5, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dohaki dohaki dohaki approved these changes

@nicholaspai nicholaspai nicholaspai approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@james-a-morris @nicholaspai @dohaki @pxrl