improve(TokenClient): Cache allowance and bondToken eth_call data #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values should rarely change. Follows strategy implemented in #1282 in the BaseAdapter (inventory manager)
nicholaspai
requested review from
mrice32,
pxrl and
james-a-morris
as code owners
pxrl
reviewed
Mar 21, 2024
pxrl
reviewed
Mar 21, 2024
pxrl
reviewed
Mar 21, 2024
This reverts commit d8b0f00.
This reverts commit c1703fb.
This reverts commit 2b2b325.
While fixing the block tag to the nearest 100_000th block when querying bondToken is nice, it breaks tests and I don't think they're worth fixing. The main motivation for taking advantage of the eth_call specific-blockTag caching is to make the code cleaner but I think this commit's refactor is nice too
|
While fixing the block tag to the nearest 100_000th block when querying bondToken is nice, it breaks tests and I don't think they're worth fixing. The main motivation for taking advantage of the eth_call specific-blockTag caching is to make the code cleaner but I think this PR's refactor is now minimally invasive |
mrice32
reviewed
Mar 22, 2024
pxrl
reviewed
Mar 22, 2024
pxrl
reviewed
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These values should rarely change. Follows strategy implemented in #1282 in the BaseAdapter (inventory manager)