feat: sampled RPC logging #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Rice <[email protected]>
Signed-off-by: Matt Rice <[email protected]>
mrice32
requested review from
nicholaspai,
pxrl and
james-a-morris
as code owners
nicholaspai
approved these changes
Mar 20, 2024
Signed-off-by: Matt Rice <[email protected]>
Signed-off-by: Matt Rice <[email protected]>
pxrl
approved these changes
Mar 20, 2024
Signed-off-by: Matt Rice <[email protected]>
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small change to sample RPC requests/responses to be sampled and logged by the provider (including latency). The sample rate is configurable s.t. an operator can produce more or fewer logs depending on their interest (or disable). The default is set to 0.1%.
My hope is that this will enable operators to pipe their logs to dashboarding tools to visualize RPC performance.
Open question: should the sample rate be set to 0 by default to keep things simple for the typical operator who may not care about these metrics?