nit(base-adapter): unneeded conditional check #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `some()` function only returns true if a match is found. An empty array calling `.some` is always guaranteed to return a falsy value. Drive-by comment on my way to getting the Linea Manager
james-a-morris
requested review from
mrice32,
nicholaspai and
pxrl
as code owners
nicholaspai
approved these changes
Mar 19, 2024
james-a-morris
commented
Mar 19, 2024
pxrl
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive-by comment on my way to getting the Linea Manager
The
some()function only returns true if a match is found. An empty array calling.somewill return a falsy value.