feat: Smarter exchange rate updates #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is from a comment added in `Dataworker.ts` that also explains this PR well:
```
// There are three times that we should look to update the HubPool's liquid reserves:
// 1. First, before we attempt to execute the HubChain PoolRebalance leaves and RelayerRefund leaves.
// We should see if there are new liquid reserves we need to account for before sending out these
// netSendAmounts.
// 2. Second, before we attempt to execute the PoolRebalance leaves for the other chains. We should
// see if there are new liquid reserves we need to account for before sending out these netSendAmounts. This
// updated liquid reserves balance could be from previous finalizations or any amountToReturn value sent
// back from the Ethereum RelayerRefundLeaves.
// 3. Third, we haven't updated the exchange rate for an L1 token on a PoolRebalanceLeaf in a while that
// we're going to execute, so we should batch in an update.
```
The motivation for this PR is to reduce the # of `exchangeRateCurrent()` calls to reduce dataworker costs. This PR should make it such that these calls are only batched with PoolRebalanceLeaf executions and never sent otherwise.
nicholaspai
requested review from
mrice32,
pxrl and
james-a-morris
as code owners
This addresses a breaking change implemented in the SDK.
mrice32
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from a comment added in
Dataworker.tsthat also explains this PR well:The motivation for this PR is to reduce the # of
exchangeRateCurrent()calls to reduce dataworker costs. This PR should make it such that these calls are only batched with PoolRebalanceLeaf executions and never sent otherwise.