refactor: Minor updates post SDK-v2 bump #1125
Conversation
pxrl
requested review from
mrice32,
nicholaspai and
james-a-morris
as code owners
|
Note also overlap with this PR: https://github.com/across-protocol/relayer-v2/pull/1124/files I'll cross-check to see whether there are any differences. |
|
I'll repurpose this to include some of the minor refactoring that isn't covered by Nick's PR. |
src/dataworker/Dataworker.ts
Outdated
| if (followingBlockNumber === undefined) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Does this change behavior?
There was a problem hiding this comment.
It shouldn't be possible, since that would require that the HubPoolClient instance was never updated. I can't see how we'd end up this deep in the code without having done that. For instance, this code lives in a loop that iterates over parsed root bundles, so if we haven't done an update then we'd never enter into the loop because there'd be nothing to iterate over.
As background, latestBlockSearched was previously defined as number | undefined, but is now defined as latestBlockSearched = 0. So to retain 100% matching logic, we'd check if (followingBlockNumber === 0), but in practice I think the check was only necessary to silence tsc "possibly undefined" warnings.
This bump clears a hurdle where some newly introduced types have been slightly renamed. The internal definitions of these types was also reorganised to use RelayData as the core/common part of each type.
This includes the recent SDK change to remove
latestBlockNumberfrom the {Hub,Spoke}PoolClient implementations.