Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hubpool balance tracking and persistence #78

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

james-a-morris
Copy link
Contributor

@james-a-morris james-a-morris commented Oct 17, 2024

Adds aggregated hub balance persistence to bundle builder service for consumption in /hubbalance api endpoint

Copy link

linear bot commented Oct 17, 2024

@james-a-morris james-a-morris force-pushed the james/acx-2445-track-hubpool-balances branch from 35176b5 to d9bcb00 Compare October 18, 2024 18:15
@james-a-morris james-a-morris changed the base branch from master to james/add-worldchain-constants October 18, 2024 18:15
@james-a-morris james-a-morris marked this pull request as ready for review October 18, 2024 18:16
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

largely a copy of bundleLeavesCache.ts but for the hub balance

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you make sure this is able to be imported from external package

packages/indexer/src/utils/contractUtils.ts Show resolved Hide resolved
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
@james-a-morris james-a-morris force-pushed the james/acx-2445-track-hubpool-balances branch from d9bcb00 to aba7ab9 Compare October 21, 2024 14:37
@james-a-morris james-a-morris changed the base branch from james/add-worldchain-constants to master October 21, 2024 14:38
Copy link
Contributor

@daywiss daywiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

packages/indexer/src/redis/hubBalancesCache.ts Outdated Show resolved Hide resolved
packages/indexer/src/services/BundleBuilderService.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@melisaguevara melisaguevara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Just one comment

Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Co-authored-by: amateima <[email protected]>
@james-a-morris james-a-morris merged commit 9889f40 into master Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants