improve(indexer): add block timestamp to depositevent data #129
Conversation
Signed-off-by: david <[email protected]>
| @@ -89,4 +89,7 @@ export class V3FundsDeposited { | |||
|
|
|||
| @CreateDateColumn() | |||
| createdAt: Date; | |||
|
|
|||
| @Column({ nullable: true }) | |||
| blockTimestamp?: number; | |||
There was a problem hiding this comment.
Is this something we will eventually backfill? Could be a good candidate to make required with the prod backfilling
There was a problem hiding this comment.
im not totally sure how this works by making it required, i wanted to avoid having to rerun indexing to get this data, and allow it optionally going forward
| @@ -46,6 +47,7 @@ export class SpokePoolRepository extends dbUtils.BlockchainEventRepository { | |||
| ...this.formatRelayData(event), | |||
| quoteTimestamp: new Date(event.quoteTimestamp * 1000), | |||
| finalised: event.blockNumber <= lastFinalisedBlock, | |||
| blockTimestamp: blockTimes[event.blockNumber], | |||
There was a problem hiding this comment.
What do you think about considering quoteTimestamp as deposit date? I know there might be a tiny difference with the actual block number though.
There was a problem hiding this comment.
I think the most accurate will be to track the time when the user's tx got mined
| private async getBlockTimesByRange( | ||
| blockRange: BlockRange, | ||
| ): Promise<Record<number, number>> { |
There was a problem hiding this comment.
I think there's room for optimisation here. Instead of passing the whole block range, we can pass here a list with only the blocks we got deposit events for.
This will avoid fetching thousands of blocks with no events during backfilling
| @@ -46,6 +47,7 @@ export class SpokePoolRepository extends dbUtils.BlockchainEventRepository { | |||
| ...this.formatRelayData(event), | |||
| quoteTimestamp: new Date(event.quoteTimestamp * 1000), | |||
| finalised: event.blockNumber <= lastFinalisedBlock, | |||
| blockTimestamp: blockTimes[event.blockNumber], | |||
There was a problem hiding this comment.
I think the most accurate will be to track the time when the user's tx got mined
Signed-off-by: david <[email protected]>
Signed-off-by: david <[email protected]>
|
@amateima I made 2 changes:
|
motivation
We want to store block timestamps with deposit data in order to calculate some metrics
changes
This adds a column "blockTimestamp" to v3FundsDeposited, and queries per block range all the block timestamps and adds it to the data when storing in database
profiling
We will use this new value and the existing "createdAt" value, which is our insertion time, for instance:
const depositWriteTime = toSeconds(deposit.createdAt) - deposit.blockTimestamp