feat: create uniform error structure #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-a-morris
force-pushed
the
james/acx-3364-implement-standard-error-structure-in-the-api
branch
from
dc9cedb to
e9ae2ea
Compare
james-a-morris
changed the base branch from
james/add-error-package
to
master
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
Signed-off-by: james-a-morris <[email protected]>
james-a-morris
force-pushed
the
james/acx-3364-implement-standard-error-structure-in-the-api
branch
from
8c54f8a to
c3b2187
Compare
amateima
reviewed
Nov 26, 2024
Comment on lines
-20
to
-30
|
|
||
| /** | ||
| * A function used by `JSON.stringify` to specify which data will be serialized | ||
| * @returns A formatted JSON | ||
| */ | ||
| public toJSON(): Record<string, unknown> { | ||
| return { | ||
| statusCode: this.httpStatusCode, | ||
| ...super.toJSON(), | ||
| }; | ||
| } |
There was a problem hiding this comment.
OOC why was this removed?
There was a problem hiding this comment.
It would add the status code to the response code but this info is already exposed via the http status code that will get thrown.
amateima
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.