This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
Multiple fixes for configurable products and add tests. #158
+903
−211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 30, 2019 21:07
Allow adding item to cart with multiple parents. Remove obsolete code related to stock rework. Update code to handle product tree, make it fast, efficient and less memory consuming.
Also make it more extendable.
nikunjkotecha
commented
Jun 3, 2019
| $sku_ids = $query->execute(); | ||
|
|
||
| if (count($sku_ids) > 1) { | ||
| $this->failedSkus[] = $product['sku'] . '(Duplicate product SKU found.)'; |
There was a problem hiding this comment.
not sure why would we fail product update, removed this code to ensure we can update products
nikunjkotecha
commented
Jun 3, 2019
| size: | ||
| label: 'Size' | ||
| type: integer | ||
| attribute_set: |
There was a problem hiding this comment.
this schema change was required to make sure tests work fine for dynamically added fields
Schema errors for acm_sku.configurable_form_settings with the following errors: acm_sku.configurable_form_settings:attribute_weights.default.color missing schema
nikunjkotecha
commented
Jun 3, 2019
| @@ -8,3 +8,5 @@ product_publish: false | |||
| api_version: v2 | |||
| filter_root_category: false | |||
| text_format: rich_text | |||
| delete_disabled_skus: true | |||
There was a problem hiding this comment.
missing config fields and schema was failing tests, haven't added update hook specifically for this one as I'm setting default values here, let me know if update hook is required (note: they are already editable via admin form)
|
Travis failure is not related to changes in PR or new tests added in PR PHPUnit tests passed: Failure: |
|
@miromichalicka @sdelbosc any feedback on this one? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.