Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-000: Add chrome support to run functional javascript test locally with ddev. #1919

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

rajeshreeputra
Copy link
Contributor

@rajeshreeputra rajeshreeputra commented Jan 9, 2025

Motivation
Currently running functional javascript test locally with ddev is not working.

Proposed changes
Add chrome support to run functional javascript test locally with ddev.

Alternatives considered
NA

Testing steps

  • Clone this repo.
  • checkout this branch using git checkout ACMS-000-ddev-chrome-support
  • install dependencies using ddev composer install
  • ssh to ddev using ddev ssh
  • Execute functional javascript test using ./vendor/bin/phpunit -c docroot/core docroot/core/modules/action/tests/src/FunctionalJavascript/ActionFormAjaxTest.php

Merge requirements

  • Major change, Minor change, Bug, Enhancement, and/or Chore label applied
  • Manual testing by a reviewer

Copy link
Collaborator

@chandan-singh7929 chandan-singh7929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishalkhode1 vishalkhode1 merged commit 75e2925 into develop Jan 9, 2025
35 of 42 checks passed
@vishalkhode1 vishalkhode1 deleted the ACMS-000-ddev-chrome-support branch January 9, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants