Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-1636: View Search Fallback is broken on ACMS install. #1663

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

deepakmishra2
Copy link
Contributor

@deepakmishra2 deepakmishra2 commented Oct 30, 2023

Motivation

Fixes #ACMS-1636

Proposed changes
Fixes fallback view for search

Alternatives considered

Testing steps
git clone develop
install site using acquia_cms_enterprise_low_code and set fallback view using commands
./vendor/bin/drush cset views.view.search display.default.display_options.empty.view_fallback.simulate_unavailable TRUE
go to site and search something and see fallback is broken including pagination.

git checkout ACMS-1636
./vendor/bin/drush cset views.view.search display.default.display_options.empty.view_fallback.simulate_unavailable TRUE
now check fallback is working fine.

For existing users

  • Go to the website and navigate to the "/user/login" page.
  • Enter the admin credentials to log in.
  • Once logged in, go to the "/admin/cohesion/templates/view_templates/view_tpl_search_fallback/edit" page.
  • In the layout canvas, locate the "Container - Pagination" section and double-click on the "Pagination" element.
  • Scroll to the bottom of the screen and, in the List style options, select "View Pagination" Click on the "Apply" button.
  • Now, drag a "Container" element from the elements panel and place it inside the "Pattern repeater" Wrap it around the "View item" section.
  • Double-click on the newly added container and, in the Layout style options, choose "Search result container" Click "Apply".
  • Finally, click on the "Save and Continue" button to save your changes.

Merge requirements

  • Major change, Minor change, Bug, Enhancement, and/or Chore label applied
  • Manual testing by a reviewer

@rajeshreeputra
Copy link
Contributor

rajeshreeputra commented Oct 30, 2023

Please include instructions to validate/incorporate with existing site.

@vishalkhode1 vishalkhode1 merged commit 325abf0 into develop Nov 6, 2023
17 checks passed
@vishalkhode1 vishalkhode1 deleted the ACMS-1636 branch November 6, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants