ACMS-1984: Moderation dashboard fix for users. #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apathak18
approved these changes
Oct 18, 2023
deepakmishra2
requested review from
rajeshreeputra,
chandan-singh7929,
vishalkhode1 and
vipin-mittal-acquia
rajeshreeputra
approved these changes
Oct 27, 2023
Comment on lines
218
to
220
| // Pattern includes all routes with entity and ends with canonical, the API | ||
| // menu will be visible only on node entities to render the jsonapi data. | ||
| elseif (preg_match('/^(media\.tasks:)?entity\.(\S*(?<!user))\.canonical$/', $id, $matches)) { |
There was a problem hiding this comment.
I don't think this statement is correct.
the API menu will be visible only on node entities to render the jsonapi data.
I can see it for taxonomy term, I think we should find root cause why its causing issue with user, rather than bypassing it.
There was a problem hiding this comment.
Even i'm not 100% sure on this solution as this looks similar to what we did to exclude users route.
There was a problem hiding this comment.
@apathak18 - As per discussion, please try pattern to bypass if its views_view:view.
apathak18
force-pushed
the
ACMS-1984
branch
4 times, most recently
from
15eb106 to
754bc18
Compare
apathak18
force-pushed
the
ACMS-1984
branch
2 times, most recently
from
dea9505 to
68e9016
Compare
chandan-singh7929
approved these changes
Nov 1, 2023
vishalkhode1
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #ACMS-1984
Proposed changes
Excluding view json task for users, as we dont see json data for users since 9.3
Alternatives considered
Testing steps
Follow steps from ticket
Merge requirements