Skip to content
This repository has been archived by the owner on May 20, 2021. It is now read-only.

zf-off-canvas does not support revealClass option. #83

Open
GCheung55 opened this issue Aug 3, 2017 · 1 comment
Open

zf-off-canvas does not support revealClass option. #83

GCheung55 opened this issue Aug 3, 2017 · 1 comment

Comments

@GCheung55
Copy link
Collaborator

From a comment in #20:

kaermorchen:
@acoustep a property "revealClass" not work in zf-off-canvas component.I try to do {{#zf-off-canvas revealClass="reveal-for-large" as |section| }} but class 'reveal-for-large' not added to element '.off-canvas.position-left'

GCheung55:
Adding revealClass="reveal-for-large" for with [email protected] isn't working either. I just tried it on the dummy app.

What did work was going into addon/templates/components/zf-off-canvas.hbs and adding reveal-for-large class to the elements with off-canvas class.

Something like:

<div class="off-canvas position-left reveal-for-large" id="zf-off-canvas-left" data-off-canvas>
   {{yield offCanvasLeftContent}}
</div>

I think we should rethink how zf-off-canvas works - maybe make it more composable with component closures?

@bravo-kernel
Copy link
Contributor

This would be most welcome

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants