Skip to content
This repository has been archived by the owner on May 20, 2021. It is now read-only.

Is there a plan to upgrade to foundation 6.2.1? #20

Closed
nadavshatz opened this issue Apr 18, 2016 · 9 comments
Closed

Is there a plan to upgrade to foundation 6.2.1? #20

nadavshatz opened this issue Apr 18, 2016 · 9 comments

Comments

@nadavshatz
Copy link

Wondering if there is a plan to upgrade this to foundation 6.2.1 and if a PR would help?

@acoustep
Copy link
Owner

PRs are more than welcome, I'll try and get on to this sorted tonight otherwise :)

@nadavshatz
Copy link
Author

@acoustep great thanks. Let me know if it ends up falling between the cracks and I'll give it a go.

@acoustep
Copy link
Owner

I've updated the Foundation version in Bower. All of the components work except for offset canvas, which I haven't had a chance to look in to properly yet.

@kaermorchen
Copy link

@acoustep I also want to say thank you. I use foundation and your addon really helped me.

@acoustep
Copy link
Owner

@kaermorchen no problem, I'm glad it's helped!

@kaermorchen
Copy link

@acoustep a property "revealClass" not work in zf-off-canvas component.I try to do {{#zf-off-canvas revealClass="reveal-for-large" as |section| }} but class 'reveal-for-large' not added to element '.off-canvas.position-left'

@andycochran
Copy link

How about 6.4.1?
(Should this issue be closed?)

@GCheung55
Copy link
Collaborator

Adding revealClass="reveal-for-large" for with [email protected] isn't working either. I just tried it on the dummy app.

What did work was going into addon/templates/components/zf-off-canvas.hbs and adding reveal-for-large class to the elements with off-canvas class.

Something like:

<div class="off-canvas position-left reveal-for-large" id="zf-off-canvas-left" data-off-canvas>
    {{yield offCanvasLeftContent}}
</div>

@GCheung55
Copy link
Collaborator

I've filed a ticket to address the revealClass issue, #83.

Closing issue because [email protected] is supported, though support is kind of buggy. Please re-open the ticket if you feel the ticket closure is in error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants