Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate split.serine for initializeParameterObject #372

Open
acope3 opened this issue Nov 5, 2021 · 0 comments
Open

Deprecate split.serine for initializeParameterObject #372

acope3 opened this issue Nov 5, 2021 · 0 comments
Assignees
@acope3

Comments

@acope3
Copy link
Owner

acope3 commented Nov 5, 2021

Based on SequenceSummary.cpp, the split.serine parameter doesn't actually do anything. Given the weak mutation assumption of ROC and FONSE, seems like we need to keep Ser4 (S) and Ser2 (Z) separate.
@acope3 acope3 self-assigned this Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acope3 acope3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acope3