Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created nav bar #19

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Created nav bar #19

merged 4 commits into from
Oct 11, 2024

Conversation

MarcusHsieh
Copy link
Collaborator

image

  • Moved /public to root
  • Created navigation.tsx and nav.ts
  • Added logo.webp

@MarcusHsieh MarcusHsieh added the ready for review Issue is done and waiting to be merged label Oct 10, 2024
@MarcusHsieh MarcusHsieh requested a review from kavinphab October 10, 2024 11:10
@MarcusHsieh MarcusHsieh self-assigned this Oct 10, 2024
@MarcusHsieh MarcusHsieh linked an issue Oct 10, 2024 that may be closed by this pull request
Copy link
Collaborator

@kavinphab kavinphab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the navigation call from page.tsx and put it in layout.tsx when you do you final commit.

Use rafce format to define functions just to make it consistent throughout code base.

The text and logo seems small could you increase the size and make the logo a bit closer to the left side.

Also your image check failed probably due to the test.txt file that is in public/gallery folder, try removing that to see if the check passes.

@MarcusHsieh
Copy link
Collaborator Author

image

Copy link
Collaborator

@kavinphab kavinphab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks great!

@kavinphab kavinphab merged commit 17df7ad into dev Oct 11, 2024
5 checks passed
kavinphab pushed a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Issue is done and waiting to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nav Bar
2 participants