Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dragon on left #53

Merged
merged 18 commits into from
Jan 27, 2025
+57 −43
Merged

dragon on left #53

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
13006cd
dragon
inegishi Jan 23, 2025
2fe0289
inegishi dragon
inegishi Jan 24, 2025
83a0135
inegishi/dragon
inegishi Jan 24, 2025
20e4d0d
Merge 83a0135137f08869403fc6e02a0c24a303f56a64 into 7d7e91a1e90bedb62…
inegishi Jan 24, 2025
a6908fc
convert images to webp
Jan 24, 2025
d765257
Merge pull request #60 from acm-ucr/acm-ucr/images_446dad8becd0af44
inegishi Jan 24, 2025
edf78d5
new dragon pic
IanNegishi Jan 25, 2025
500a7b0
new pic
IanNegishi Jan 25, 2025
5326175
new pic
IanNegishi Jan 25, 2025
553480f
Merge 5326175e2ac96d3a27b61ebbb54396efa9c259fe into f2c41233cc33d58d0…
inegishi Jan 25, 2025
b118688
Merge branch 'dev' into inegishi/dragon
inegishi Jan 25, 2025
e12c5a8
convert images to webp
Jan 25, 2025
c1f54ec
Merge pull request #61 from acm-ucr/acm-ucr/images_95415c9302cfae3a
stanleylew5 Jan 27, 2025
a4c2430
comment fix
IanNegishi Jan 27, 2025
b01c121
comment fix
IanNegishi Jan 27, 2025
f83f9e0
comment fix
IanNegishi Jan 27, 2025
7832339
fix
IanNegishi Jan 27, 2025
b7be698
Merge branch 'dev' into inegishi/dragon
stanleylew5 Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 54 additions & 43 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added public/home/dragon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 14 additions & 3 deletions src/app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,22 @@ import QuoteBox from "@/components/home/QuoteBox";
import quotes from "@/data/quote-data";
import EHTitle from "@/components/events/EventHighlightsTitle";
import MissionStatement from "@/components/home/MissionStatement";

import Image from "next/image";
const Home = () => {
return (
<div className="bg-csa-tan-100 pt-[12.2vh] md:pt-[14.4vh]">
<MissionStatement />
<div className="bg-csa-tan-100">
<div className="grid grid-flow-col grid-rows-3 gap-4">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div className="grid grid-flow-col grid-rows-3 gap-4">
<div className="grid grid-flow-col grid-rows-3 gap-4">

you're doing a lot of extra work than you need to, all you have to do is absolutely position the dragon to the left side of the page

<Image
src="/home/dragon.png"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
src="/home/dragon.png"
src="/home/dragon.png"

Import it at the top as so --
Import Dragon from "@/public/home/dragon.png"
then your src here will just be src={Dragon}

alt="dragon"
width={450}
height={450}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't hardcode these properties

className="row-span-3"
/>
<div className="col-span-2 row-span-2 row-start-3">
<MissionStatement />
</div>
</div>
<EHTitle />
<XinDescription />
{quotes.map(({ quote, person }, index) => (
Expand Down
Loading