Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Academic Component #47

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Add Academic Component #47

merged 6 commits into from
Jan 22, 2025

Conversation

xxiyun
Copy link
Collaborator

@xxiyun xxiyun commented Jan 21, 2025

image

@xxiyun xxiyun self-assigned this Jan 21, 2025
@xxiyun xxiyun linked an issue Jan 21, 2025 that may be closed by this pull request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you see your code, it looks like you're trying to add a background with certain dimensions when you can just use a border and you're trying to have your div start on the right side of the page -- you're overcomplicating it. try referencing this sample code I've written. it's basically your code but more optimized. you'll need to still style the text, etc but this should look more clean.

<div className="flex justify-end">
      <div className="relative h-[12vh] w-[25vw] border-8 border-csa-gray-100 rounded-3xl flex items-center">
         ......
      </div>
</div>

@xxiyun
Copy link
Collaborator Author

xxiyun commented Jan 21, 2025

image

Copy link
Contributor

@stanleylew5 stanleylew5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
this is how it looks like on my side, you're going to need to decrease the font size, increase the width of the div, and let's use a mr-[#vw] other than mr-28 since 28 is a relatively large value

@xxiyun
Copy link
Collaborator Author

xxiyun commented Jan 22, 2025

image
i made the changes you requested but i'm not sure if it's fully correct because on my screen, the website does not reflect what your screen shows. any suggestions on how to fix it?

Copy link
Contributor

@stanleylew5 stanleylew5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@stanleylew5 stanleylew5 merged commit 6daa8a8 into dev Jan 22, 2025
5 checks passed
@stanleylew5 stanleylew5 deleted the xxiyun/AcademicComponent branch January 22, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Academic Component
2 participants