Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to GHC 9.4.8 and HLS 2.5.0.0 #73

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Upgrade to GHC 9.4.8 and HLS 2.5.0.0 #73

merged 3 commits into from
Jan 10, 2024

Conversation

tfausak
Copy link
Contributor

@tfausak tfausak commented Dec 1, 2023 •
edited
Loading

Fixes #69.

  • I manually tested the code locally to make sure that it works.
  • If there is documentation, I made sure it's accurate and up to date.
  • If possible, I wrote automated tests for the new behavior.

@tfausak
Copy link
Contributor Author

tfausak commented Dec 1, 2023

Ah, this is blocked until this version of HLS gets added to the default channel. Currently it's only in the "vanilla" channel. I could switch over to using that, but I'd prefer to stick with the defaults. See haskell/ghcup-metadata#159.

@tfausak tfausak marked this pull request as draft December 1, 2023 18:17
@saramuse
Copy link

saramuse commented Dec 1, 2023

@tfausak did you pair with Finn on these?

@tfausak tfausak marked this pull request as ready for review January 9, 2024 14:11
@tfausak tfausak merged commit 8629871 into main Jan 10, 2024
10 checks passed
@tfausak tfausak deleted the gh-69-ghc-9.4.8 branch January 10, 2024 17:12
@tfausak tfausak mentioned this pull request Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codygman codygman codygman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to GHC 9.4.8
3 participants
@tfausak @saramuse @codygman