IP filter functionality for making orders #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acidjunk
commented
Aug 17, 2021
There was a problem hiding this comment.
@Georgi2704 some comments and if possible I would like to see a unit test also.
server/apis/v1/users.py
Outdated
| @@ -32,7 +32,7 @@ | |||
| @api.route("/") | |||
| @api.doc("Show all users to staff users.") | |||
| class UserResourceList(Resource): | |||
| @roles_accepted("admin") | |||
| # @roles_accepted("admin") | |||
There was a problem hiding this comment.
There are a lot of places now without auth...
server/utils.py
Outdated
|
|
||
|
|
||
| def is_ip_allowed(request, shops_IP_whitelist, shop_id): | ||
| if (shop_id in shops_IP_whitelist): |
There was a problem hiding this comment.
more pythonesk to use: shops_IP_whitelist.get(shop_id)
There was a problem hiding this comment.
i ll do that in the next commits
server/apis/v1/orders.py
Outdated
| @@ -216,6 +220,14 @@ def post(self): | |||
| save(order) | |||
| return order, 201 | |||
|
|
|||
| @api.route('/iptest') | |||
|
|
||
| # 5 gram check | ||
| # 5 gram checks |
There was a problem hiding this comment.
probably clicked backspace
server/apis/v1/orders.py
Outdated
| @@ -58,7 +60,7 @@ | |||
| "order_info": fields.Nested(order_info_serializer), | |||
| # "order_info": fields.String(), | |||
| "total": fields.Float(required=True, description="Total"), | |||
| "customer_order_id": fields.Integer, | |||
| "customer_ord er_id": fields.Integer, | |||
.idea/.gitignore
Outdated
| @@ -0,0 +1,8 @@ | |||
| # Default ignored files | |||
There was a problem hiding this comment.
hmm: I normally list the complete ".idea" folder in my root .gitignore
A nice test of your git skills: remove the .idea folder fromthis branch and add the .idea folder to the root ignore file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.