webcave: Move compose file to repo root #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markoburcul
force-pushed
the
adapt-repo-for-backend-deployment
branch
2 times, most recently
from
679b60b to
75316f9
Compare
Move compose file for webcave server to repo root since it is needed by the infra role with which we will deploy it. Updated the compose file to be compatible with environment variable forwarding from the ansible role. Namely, we need PORT, IS_BEHIND_PROXY and CLIENT_ORIGIN_URL to be read from environment of the process starting the containers. Also, in the case these values are not present or empty, just use the default ones. Update Readme file to reflect changes. Referenced issue: status-im/infra-misc#308 Signed-off-by: markoburcul <[email protected]>
markoburcul
force-pushed
the
adapt-repo-for-backend-deployment
branch
from
75316f9 to
bdcefb4
Compare
pajicf
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move compose file for webcave server to repo root since it is needed by the infra role with which we will deploy it.
Referenced issue: https://github.com/status-im/infra-misc/issues/308
What does this PR resolve? 🚀
Details 📝
The compose file is needed to be in the repo root so we can deploy the webcave server with infra role for docker compose.
Checklist ✅