Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix group counting #99

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix: fix group counting #99

merged 2 commits into from
Oct 23, 2024

Conversation

lu-pl
Copy link
Contributor

@lu-pl lu-pl commented Oct 18, 2024 •
edited
Loading

Fixes #98.

@lu-pl lu-pl marked this pull request as draft October 18, 2024 05:29
@lu-pl lu-pl mentioned this pull request Oct 18, 2024
Closed
@lu-pl lu-pl force-pushed the lupl/fix-group-counting branch 2 times, most recently from b84819f to 1a75025 Compare October 23, 2024 10:11
@lu-pl lu-pl marked this pull request as ready for review October 23, 2024 10:12
@lu-pl lu-pl requested a review from b1rger October 23, 2024 10:12
b1rger
b1rger requested changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@b1rger b1rger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a commit message to the first commit - "fix: fix group counting" does neither tell me which problem you try to fix nor how you implemented the fix. also one fix is enough

@lu-pl lu-pl force-pushed the lupl/fix-group-counting branch from 1a75025 to fe18352 Compare October 23, 2024 10:23
@lu-pl lu-pl requested a review from b1rger October 23, 2024 10:24
b1rger
b1rger requested changes Oct 23, 2024
View reviewed changes
tests/data/models/dummy_model.py Outdated Show resolved Hide resolved
@lu-pl lu-pl force-pushed the lupl/fix-group-counting branch from fe18352 to e934c15 Compare October 23, 2024 10:32
@lu-pl lu-pl requested a review from b1rger October 23, 2024 10:32
@lu-pl lu-pl merged commit 7402dc7 into main Oct 23, 2024
9 checks passed
lu-pl added a commit that referenced this pull request Oct 23, 2024
@lu-pl
fix: adapt count query generator to correctly count grouped models
affe933 
Fixes #99.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1rger b1rger b1rger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page total count does not work for grouped models
2 participants
@lu-pl @b1rger