lupl/basic logging #186
Closed
lupl/basic logging #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a very basic SPARQL pretty printer, mainly for logging output. The implementation is kind of crude with C-style array appending, but strings are immutable, so append/join is actually a cheaper solution than recursive string construction. Doing anything with SPARQL queries without a proper SPARQL parser that handles validation, serialization etc. is basically a kludge. Just saying.
The changes introduces basic INFO and DEBUG logging for SPARQLModelAdapter __init__ and query. Currently available log levels are "INFO" and "DEBUG", the log level can be set with log_level parameter (default "INFO"). Closes #163.
lu-pl
force-pushed
the
lupl/basic-logging
branch
from
cb64a45 to
29b0157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163