Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query strategies #167

Merged
merged 3 commits into from
Dec 11, 2024
Merged

feat: query strategies #167

merged 3 commits into from
Dec 11, 2024

Conversation

lu-pl
Copy link
Contributor

@lu-pl lu-pl commented Dec 10, 2024

Closes #169 .

@lu-pl lu-pl force-pushed the lupl/query-strategies branch 3 times, most recently from d1a87cf to 57359fa Compare December 10, 2024 10:18
@lu-pl lu-pl force-pushed the lupl/query-strategies branch from 57359fa to b6fd8f9 Compare December 10, 2024 10:31
@lu-pl lu-pl marked this pull request as draft December 10, 2024 11:13
@lu-pl lu-pl force-pushed the lupl/query-strategies branch 2 times, most recently from ec8cae0 to f860791 Compare December 11, 2024 12:55
@lu-pl lu-pl marked this pull request as ready for review December 11, 2024 12:56
@lu-pl lu-pl requested a review from kevinstadler December 11, 2024 12:56
Currently, rdfproxy relies on SPARQLWrapper for querying triplestores;
this is not ideal since SPARQLWrapper occasionally gets
blacklisted e.g. by wikidata and caused severe performance issues in
the past.

The change introduces SPARQLQuery strategies for better control over
what SPARQL query backend should run in RDFProxy. The
SPARQLWrapperStrategy, implements exactly the previous SPARQLWrapper behavior.
An HttpxStrategy (default) implements the query functionality required by
RDFProxy using raw httpx instead of SPARQLWrapper.

Closes #169.
@lu-pl lu-pl force-pushed the lupl/query-strategies branch from f860791 to 8e32a05 Compare December 11, 2024 13:38
@lu-pl lu-pl merged commit 088509b into main Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SPARQLQuery strategies for SPARQLWrapper and httpx
2 participants