Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement rdfproxy.ConfigDict for model config #160

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

lu-pl
Copy link
Contributor

@lu-pl lu-pl commented Dec 3, 2024

Closes #159 .

@lu-pl lu-pl force-pushed the lupl/rdfproxy-configdict branch from 890f0e7 to 6f5696a Compare December 3, 2024 10:48
@lu-pl lu-pl requested a review from b1rger December 3, 2024 10:49
@lu-pl lu-pl changed the title Lupl/rdfproxy configdict feat: implement rdfproxy.ConfigDict for model config Dec 3, 2024
@lu-pl lu-pl force-pushed the lupl/rdfproxy-configdict branch from 6f5696a to 006d9d7 Compare December 3, 2024 14:55
@b1rger b1rger removed their request for review December 3, 2024 14:55
@lu-pl lu-pl force-pushed the lupl/rdfproxy-configdict branch from 006d9d7 to 7c74b05 Compare December 3, 2024 14:57
@lu-pl lu-pl requested a review from kevinstadler December 3, 2024 14:59
lu-pl added 3 commits December 5, 2024 14:10
Currently, the rdfproxy custom settings for pydantic.ConfigDict are rightfully flagged by static checkers.
Subclassing pydantic.ConfigDict and providing rdfproxy-specific config
options solves this problem and provides better IDE support for
instantiating model configs.

Closes #159.
@lu-pl lu-pl force-pushed the lupl/rdfproxy-configdict branch from 7c74b05 to fda47b5 Compare December 5, 2024 13:12
@kevinstadler kevinstadler merged commit 516c645 into main Dec 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define an rdfproxy.ConfigDict
2 participants