feat: query parameter model #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-pl
force-pushed
the
lupl/query-parameter-model
branch
from
0e35976 to
2b9c406
Compare
kevinstadler
approved these changes
Nov 28, 2024
|
None of the commits explain the "why" |
Using a query parameter model for SPARQLModelAdapter.query has many advantages, e.g. enhanced OpenAPI/Swagger definitions for FastAPI code and runtime validation for query parameters. Also, the query parameter model defines a single extension interface for query parameters. Closes #150.
lu-pl
force-pushed
the
lupl/query-parameter-model
branch
from
2b9c406 to
8bf117c
Compare
kevinstadler
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150.