Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/playwright integration #9

Merged
merged 9 commits into from
Jan 29, 2024
Merged

Feat/playwright integration #9

merged 9 commits into from
Jan 29, 2024

Conversation

oliviareichl
Copy link
Member

merge playwright integration into develop.

stefanprobst
stefanprobst reviewed Jan 23, 2024
View reviewed changes
tests/MainPage.test.ts Outdated Show resolved Hide resolved
tests/MainPage.test.ts Outdated Show resolved Hide resolved
tests/MainPage.test.ts Outdated Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
tests/MainPageToOthers.test.ts Outdated
return;
}
await page.locator('[data-test="main-map-btn"]').click();
await expect(page.locator('[data-test="map-page-container"]')).toBeVisible();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also check for toHaveURL?

stefanprobst
stefanprobst reviewed Jan 26, 2024
View reviewed changes
pages/index.vue Outdated
@@ -45,26 +45,26 @@ const contentToUse = computed(() => {
<VCol cols="auto">
<VBtn
size="large"
role="button"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't do this. <VBtn to="/"> renders an anchor tag <a href="/">, so it should be targeted with getByRole("link")

stefanprobst
stefanprobst reviewed Jan 26, 2024
View reviewed changes
pages/index.vue Outdated
>
{{ $t("global.basics.map") }}
</VBtn>
</VCol>
<VCol cols="auto">
<VBtn
size="large"
role="button"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@stefanprobst
Copy link

stefanprobst commented Jan 26, 2024 •
edited
Loading

follow-up PR should refactor locale-dependent tests to either only run for defaultLocale, or all locales. this will require using vue-i18n for getting translations in tests, instead of hard-coding strings for accessible names.

@oliviareichl oliviareichl marked this pull request as ready for review January 29, 2024 13:05
@stefanprobst stefanprobst merged commit f6c286f into develop Jan 29, 2024
5 checks passed
@stefanprobst stefanprobst deleted the feat/playwright-integration branch January 29, 2024 13:06
@oliviareichl oliviareichl restored the feat/playwright-integration branch October 16, 2024 12:12
@oliviareichl oliviareichl deleted the feat/playwright-integration branch October 16, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprobst stefanprobst stefanprobst left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviareichl @stefanprobst