-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Docker image + sample_project entrypoint & setup #877
Conversation
4446c27
to
be52dd3
Compare
be52dd3
to
eacb6ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with apis_core.urls
added to /apis
this is not working out of the box. In the sample_project
we should include apis_core.urls
as the root: urlpatterns = [path("", include("apis_core.urls", namespace="apis"))]
instead.
Also with the current setup creation of any links in the sample_project fails due to #884
So we should either rename the sample_project (at least in the docker-image) or fix #884 before merging this.
I think we should fix #876 instead. Including the apis URIs in a specific namespace should not be a requirement for a running instance. |
makes sense. But my comment was regarding the path where |
Ah, oke, thanks for clarifying, then we are on the same page, that it should work with whereever we include I can not reproduce the login not redirecting correctly - how did you login? (I can reproduce the logout not redirecting correctly, though - this seems to be this problem, although I'm not sure why that did not come up yet) |
when the url is at "/apis", you are not logged in and you click on lets say "Person" (to go to the list of persons) it redirects to /accounts/login/ but the login page is actually under "/apis/accounts/login/" |
Ah, yes, indeed! But I'm not sure if we can make this run out of the box. |
ok, this solves the accounts urls problem (one or the other way), but still the root url of the sample_project doesnt serve anything. So why not just change the path from |
44573ff
to
acd2faf
Compare
acd2faf
to
89fab2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely, apart from the fact that when properties are added, server needs to be restarted to actually get the relation forms. Given that this is another issue I opened #914
Closes: #602