fix(history): use signal instead of method for setting timestamp #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1rger
force-pushed
the
birger/fix-history-delete
branch
from
fb89ab3 to
74630a9
Compare
When doing a CASCADING delete, the `delete` method of an instance is not called, but the `pre_delete` signal is triggered. We want to set the current date for the `_history_date` attribute, if it is None. To do that also in cascading deletes, we use the pre_delete signal. Closes: #814
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a CASCADING delete, the
deletemethod of an instance is notcalled, but the
pre_deletesignal is triggered. We want to set thecurrent date for the
_history_dateattribute, if it is None. To dothat also in cascading deletes, we use the pre_delete signal.
Closes: #814