Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(history): move get_diff method to APISHistoryTableBase #801

Merged
merged 1 commit into from
May 6, 2024

Conversation

b1rger
Copy link
Contributor

@b1rger b1rger commented Apr 25, 2024

No description provided.

@b1rger b1rger marked this pull request as ready for review April 25, 2024 18:59
@b1rger b1rger requested review from sennierer and removed request for sennierer April 25, 2024 18:59
@b1rger b1rger marked this pull request as draft April 25, 2024 19:03
@b1rger b1rger force-pushed the birger/history-filter-utils branch 2 times, most recently from cf9c0c9 to 81e0145 Compare April 25, 2024 19:22
@b1rger b1rger changed the title refactor(history): move changes filter to utils function refactor(history): move get_diff method to APISHistoryTableBase Apr 25, 2024
@b1rger b1rger marked this pull request as ready for review April 25, 2024 19:24
@b1rger b1rger force-pushed the birger/history-filter-utils branch 2 times, most recently from 75230d9 to 908a2ca Compare April 26, 2024 08:36
@b1rger b1rger requested a review from sennierer April 26, 2024 08:38
Having the `get_diff` method as part of the historical record itself has
the advantage that it can be used from different parts of the code.
@b1rger b1rger force-pushed the birger/history-filter-utils branch from 908a2ca to 6118561 Compare April 26, 2024 10:27
@b1rger b1rger merged commit 507aa4a into main May 6, 2024
11 checks passed
@b1rger b1rger deleted the birger/history-filter-utils branch May 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant