refactor(utils): use contenttype instead of model name for helper #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1rger
force-pushed
the
birger/254-refactor-get_classes
branch
from
6fe65c6 to
7af6000
Compare
b1rger
force-pushed
the
birger/254-refactor-get_classes
branch
4 times, most recently
from
5549d48 to
b4d8486
Compare
The `get_classes_with_allowed_relation_from` method created a list of possible related models based on the name of one model. It then returned the names of those models as strings. It makes more sense to simply use contenttypes instead of model names, especially since the Property model stores the possible subj and obj classes as ContentTypes. This commit refactors the method and also updates `triple_sidebar` which is the only function that uses the `get_classes_with_allowed_relation_from` method. Closes: #254
b1rger
force-pushed
the
birger/254-refactor-get_classes
branch
from
b4d8486 to
4a877fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_classes_with_allowed_relation_frommethod created a list ofpossible related models based on the name of one model. It then returned
the names of those models as strings. It makes more sense to simply use
contenttypes instead of model names, especially since the Property model
stores the possible subj and obj classes as ContentTypes.
This commit refactors the method and also updates
triple_sidebarwhichis the only funciton that uses the
get_classes_with_allowed_relation_frommethod.Closes: #254