refactor: move column selector from form to table #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1rger
force-pushed
the
birger/173-addcol
branch
from
63701a7 to
317d7ed
Compare
This commit changes the way the `column_selector` is set up. Up until
now, it was a simple select input, that could only be used in
conjunction with an existing form. That meant, that the colums selector
had to be places at a position away from the actual table.
Now the column selector is its own form, therefore it can be places
whereever we want it. Also it is not a templatetag anymore, but a simple
partial template that has to be included with {% include ... %}.
The downside is, that we might now have multiple forms sending get
parameters - this is where the new "form_get_hidden.html" template comes
in. It adds existing get parameters to hidden fields in the form, that
way multiple forms don't get in each others way.
Closes: #173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #173