Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: move methods from TempEntityClass to AbstractEntity #305

Merged
merged 1 commit into from
Oct 12, 2023
Merged

refactor!: move methods from TempEntityClass to AbstractEntity #305

merged 1 commit into from
Oct 12, 2023

Conversation

b1rger
Copy link
Contributor

@b1rger b1rger commented Sep 25, 2023

Closes: #304

@b1rger b1rger force-pushed the birger/304-move-entity-methods branch from e55c950 to 0f9a324 Compare September 25, 2023 14:21
@b1rger b1rger marked this pull request as ready for review September 26, 2023 09:25
@b1rger b1rger force-pushed the birger/304-move-entity-methods branch 2 times, most recently from ed315e8 to 5025328 Compare October 5, 2023 08:01
sennierer
sennierer approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@sennierer sennierer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the breaking change can be removed. Given that all functions are moved in abstractbaseclass and tempentitybaseclass inherits from abstractbaseclass I dont see the breaking change

@b1rger b1rger force-pushed the birger/304-move-entity-methods branch from 5025328 to a04212a Compare October 12, 2023 12:35
@b1rger b1rger merged commit c60e6df into main Oct 12, 2023
@b1rger b1rger deleted the birger/304-move-entity-methods branch October 13, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sennierer sennierer sennierer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move methods from TempEntityClass to AbstractEntity
2 participants
@b1rger @sennierer