Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: drop apis module #300

Merged
merged 1 commit into from
Oct 4, 2023
Merged

refactor!: drop apis module #300

merged 1 commit into from
Oct 4, 2023

Conversation

b1rger
Copy link
Contributor

@b1rger b1rger commented Sep 25, 2023

The apis module provided default settings for apis instances at the
ACDH-CH. It was moved to a separate repository and lives now under
https://github.com/acdh-oeaw/apis-acdhch-default-settings

This commit therefore removes the apis module. The apis module also
contained the settings for running tests in the github CI - this
settings file now resides in tests/settings_ci.py

Closes: #222

@b1rger b1rger marked this pull request as ready for review September 25, 2023 12:59
@b1rger b1rger added needs-attention This issue or pull request is in need of discussion, information, assessment by team members breaking-change Changes which may cause errors/failures without prior inspection/revision of other code or config labels Sep 25, 2023
@sennierer sennierer removed the needs-attention This issue or pull request is in need of discussion, information, assessment by team members label Oct 4, 2023
The `apis` module provided default settings for apis instances at the
ACDH-CH. It was moved to a separate repository and lives now under
https://github.com/acdh-oeaw/apis-acdhch-default-settings

This commit therefore removes the `apis` module. The `apis` module also
contained the settings for running tests in the github CI - this
settings file now resides in tests/settings_ci.py

Closes: #222
@b1rger b1rger merged commit cd16eb1 into main Oct 4, 2023
6 checks passed
@b1rger b1rger deleted the birger/drop-apis branch October 11, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes which may cause errors/failures without prior inspection/revision of other code or config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move apis module to a separate repository
2 participants